Skip to content

Environment github-pages not found error is misleading #299

@jsoref

Description

@jsoref

warn(`Environment ${environmentName} not found`);

triggers:

GET /repos/check-spelling-sandbox/check-spelling-coverage/environments/github-pages/variables?per_page=100 - 404 with id FDA3:311957:1AF59:75D5D:6968F39D in 104ms
[Warn  - 9:03:09 AM] Environment github-pages not found

That error is wrong.

The environment exists:

gh api '/repos/check-spelling-sandbox/check-spelling-coverage/environments'                     
{
  "total_count": 1,
  "environments": [
    {
      "id": 11298787771,
      "node_id": "EN_kwDOQ6a6es8AAAACoXXRuw",
      "name": "github-pages",
      "url": "https://api.github.com/repos/check-spelling-sandbox/check-spelling-coverage/environments/github-pages",
      "html_url": "https://github.com/check-spelling-sandbox/check-spelling-coverage/deployments/activity_log?environments_filter=github-pages",
      "created_at": "2026-01-15T14:06:18Z",
      "updated_at": "2026-01-15T14:06:18Z",
      "can_admins_bypass": true,
      "protection_rules": [
        {
          "id": 46106295,
          "node_id": "GA_kwDOQ6a6es4Cv4a3",
          "type": "branch_policy"
        }
      ],
      "deployment_branch_policy": {
        "protected_branches": false,
        "custom_branch_policies": true
      }
    }
  ]
}

It might not have any variables, and that might be worth reporting (or not). But telling users that the environment doesn't exist when it does is not ok.

I'm not sure if that's what's causing this, but I'm confident this bug should be fixed and then maybe someone can fix the output that caused me to look under the hood:
Value 'github-pages' is not valid

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions