Feature - Bearer Token Authentication and SSL Certificate Support for JIRA

[chiragjagga]

• Added new JiraApiBearerToken credential for storing bearer token credential.
• Added enable SSL button (default : false) for better UX and field to add SSL certificate if button is enabled.
• Added dynamic API version in API calls as Jira Server/DC uses v2 whereas jira cloud uses v3 for API.
• Backward compatible with no effect on existing jira tools.
• Implements the enhancement in Add Bearer Token Authentication and SSL Certificate Support for JIRA Tool #5594

Add Credential:

Tool UI:

SSL Certificate Upload

Workflow:
To test the SSL certificate I created an nginx proxy with a self signed certificate and put the jira host behind this proxy. On presenting a valid CA certificate the request was passed to the jira instance correctly.

JiraBearerToken_Compressed.mp4

[gemini-code-assist]

Summary of Changes

Hello @chiragjagga, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Jira integration by introducing support for bearer token authentication, which is crucial for Jira Server and Data Center instances using Personal Access Tokens. It also adds robust SSL certificate handling, allowing users to establish secure connections to their Jira environments. Furthermore, the integration now intelligently adapts to different Jira API versions (v2 for Server/DC and v3 for Cloud) based on the chosen authentication method, making the tool more versatile and future-proof without impacting existing setups.

Highlights

• Bearer Token Authentication: Introduced a new JiraApiBearerToken credential type to support Personal Access Tokens (PAT) for Jira Server/Data Center, enhancing authentication flexibility.
• SSL Certificate Support: Added functionality to enable and upload SSL certificates (.pem or .crt files) for secure connections to Jira instances, improving security and compatibility.
• Dynamic API Versioning: Implemented dynamic API versioning for Jira API calls, automatically using v2 for Bearer Token (Server/DC) and v3 for Basic Auth (Cloud), ensuring correct API interaction across different Jira environments.
• Backward Compatibility: Ensured that all new features are backward compatible, meaning existing Jira tool configurations using basic authentication remain unaffected.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces valuable enhancements to the Jira tool by adding support for Bearer Token authentication and custom SSL certificates. This greatly improves flexibility for connecting to different Jira environments like Server/Data Center. The implementation is generally solid, with new credential types and UI options. I've identified a critical bug in how SSL certificates from data URIs are parsed, which would prevent them from working correctly, and a couple of medium-severity issues related to fragile filename parsing and inefficient creation of HTTPS agents that could be improved for robustness and performance. My review includes specific code suggestions to address these points. The provided rule regarding authorization checks for internal vs. external API endpoints does not apply to the identified issues.