completed issue 12517, implemented new module for otlp config along with test checking jvm metric export using mock server #16023
+534
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16023 +/- ##
============================================
+ Coverage 60.74% 60.76% +0.01%
- Complexity 11750 11752 +2
============================================
Files 1949 1952 +3
Lines 88898 88960 +62
Branches 13407 13412 +5
============================================
+ Hits 54002 54057 +55
- Misses 29337 29342 +5
- Partials 5559 5561 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zrlw
changed the title
manasagar
force-pushed
the
up-dev-issue#12517
branch
from
bcfa13a to
da896b8
Compare
zrlw
reviewed
Jan 20, 2026
| <dependency> | ||
| <groupId>com.google.protobuf</groupId> | ||
| <artifactId>protobuf-java</artifactId> | ||
| <version>4.32.0</version> |
Contributor
There was a problem hiding this comment.
the version defined at dubbo-dependencies-bom is not suitable for this model?
Author
There was a problem hiding this comment.
Yes it was giving runtime error with the defined version
Author
There was a problem hiding this comment.
java.lang.NoClassDefFoundError: com/google/protobuf/RuntimeVersion$RuntimeDomain
at io.opentelemetry.proto.resource.v1.Resource.<clinit>(Resource.java:22)
at io.micrometer.registry.otlp.OtlpMeterRegistry.<init>(OtlpMeterRegistry.java:129)
at io.micrometer.registry.otlp.OtlpMeterRegistry.<init>(OtlpMeterRegistry.java:118)
at io.micrometer.registry.otlp.OtlpMeterRegistry.<init>(OtlpMeterRegistry.java:107)
at org.apache.dubbo.metrics.otlp.OtlpMetricsReporter.<init>(OtlpMetricsReporter.java:57)
at org.apache.dubbo.metrics.otlp.OtlpMetricsReporterFactoryTest.export_Test(OtlpMetricsReporterFactoryTest.java:114)
at java.base/java.lang.reflect.Method.invoke(Method.java:565)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
we are using 3.8 while we needed 4.32
Contributor
There was a problem hiding this comment.
the version defined at dubbo-dependencies-bom had been bumped to 4.33.4 by recent PR, so it's redundant now.
zrlw
reviewed
Jan 20, 2026
| <dependency> | ||
| <groupId>com.squareup.okhttp3</groupId> | ||
| <artifactId>mockwebserver</artifactId> | ||
| <version>4.12.0</version> |
Contributor
There was a problem hiding this comment.
it's redundant as the same version has been defined at dubbo-dependencies-bom
manasagar
force-pushed
the
up-dev-issue#12517
branch
2 times, most recently
from
4b987d4 to
0f05baf
Compare
…ith test checking jvm metric export using mock server
manasagar
force-pushed
the
up-dev-issue#12517
branch
from
ec1c313 to
23b1715
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
For issue #12517
based on #14067
Checklist