Ankitml/upstream comments #333
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GitGraphAnalyzer class for finding previous benchmarks based on git ancestry instead of execution time. This fixes release branch comparisons where PRs were comparing against wrong baseline commits. - Add src/gitGraph.ts with git analysis functions - Modify addBenchmarkEntry.ts to use git-graph aware previous benchmark selection - Update default_index_html.ts to sort visualization data by commit timestamp Fixes #3769
Add comprehensive tests for GitGraphAnalyzer and addBenchmarkEntry integration. All 227 tests pass successfully.
Co-authored-by: Stu Hood <stuhood@gmail.com> Signed-off-by: Ankit <573824+ankitml@users.noreply.github.com>
Ankitml/git graph awareness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switches addBenchmarkEntry to use a singleton GitGraphAnalyzer