fix(worker): Remove repo/commit from LockRetry message for proper Sentry grouping #673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #668 removed the lock name from the
LockRetryerror message but leftRepo: {repoid}, Commit: {commitid}in the message. Since each repo/commit combination is unique, Sentry was still creating separate issues for each occurrence instead of grouping them together.Evidence from production (release
production-release-482156a):Solution
Remove repo and commit from the error message string entirely. The message is now just:
All identifying information remains available in:
exc.lock_name,exc.repoid,exc.commitid)lock_acquisitioncontext with full details)lock_name,lock_type)Test Plan
test_lock_manager.py)Fixes CCMRG-2031
Note
Makes
LockRetryexception message generic to improve Sentry issue grouping while preserving identifiers in attributes and Sentry context/tags.LockRetry.__init__to removerepoid/commitidfrom the max-retries error message; adds comment explaining grouping rationaleWritten by Cursor Bugbot for commit cfcc482. This will update automatically on new commits. Configure here.