Kotlin: Load kotlin extractor last #21216
Open
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be able to capture expansions from other extensions
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the Kotlin extractor to ensure it loads as the last IR generation extension, allowing it to capture code expansions generated by other compiler plugins like kotlinx.serialization. This addresses test output changes observed when upgrading to Kotlin 2.3.0.
Changes:
- Modified extension registration to use
LoadingOrder.LASTinstead of default loading order - Changed from using the convenience method
IrGenerationExtension.registerExtension()to directly accessing the extension point API to specify loading order
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the Kotlin extractor is loaded as the last extension to be able to capture expansions from other extensions.
This addresses the changes in test output observed when upgrading to [support Kotlin 2.3.0.] (#20965)