C++: Enforce more uniqueness in Buffer.qll
#21219
Draft
+35
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We received a number of FP reports at Microsoft related to buffer overflow queries that all involve inconsistency in DBs. Sadly, I don't have access to any tracer logs so that we can debug why these inconsistencies happen, and I haven't been able to reproduce it with any locally build DBs.
The main problem is that a
structhas multiple sizes, and this PR mitigates the problem by restricting theBuffer.qlllibrary (which is used in a number of overflow-related queries) to only types with unique type sizes.Since I haven't been able to reproduce the problem I also haven't been able to provide a testcase.
Commit-by-commit review recommended.