-
-
Notifications
You must be signed in to change notification settings - Fork 806
Allow sorting applications #909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Inlined the package, as it hasn't received many updates, and uses a custom domain for importing the repo.
Co-authored-by: Xavier <buzz.eclair@gmail.com>
In case of errors in tests, having the database log bloats the output and makes the errors hard to detect.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #909 +/- ##
==========================================
- Coverage 79.15% 78.70% -0.46%
==========================================
Files 56 57 +1
Lines 2226 2517 +291
==========================================
+ Hits 1762 1981 +219
- Misses 360 397 +37
- Partials 104 139 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eternal-flame-AD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
| // example: AWH0wZ5r0Mbac.r | ||
| Token string `gorm:"type:varchar(180);uniqueIndex:uix_applications_token" json:"token"` | ||
| UserID uint `gorm:"index" json:"-"` | ||
| UserID uint `gorm:"index;uniqueIndex:idx_id_sortkey,priority:1" json:"-"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use the existing name convention (uix_application_user_id_sortkey)
Supercedes #856
See #804
Fixes #358