Skip to content

Conversation

@jmattheis
Copy link
Member

Supercedes #856
See #804
Fixes #358

image

jmattheis and others added 5 commits January 24, 2026 12:59
Inlined the package, as it hasn't received many updates, and uses a
custom domain for importing the repo.
Co-authored-by: Xavier <buzz.eclair@gmail.com>
In case of errors in tests, having the database log bloats the output
and makes the errors hard to detect.
@jmattheis jmattheis requested a review from a team as a code owner January 24, 2026 12:29
@jmattheis jmattheis mentioned this pull request Jan 24, 2026
@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 74.91639% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.70%. Comparing base (cc2fae5) to head (ac81923).

Files with missing lines Patch % Lines
fracdex/fracdex.go 76.40% 30 Missing and 29 partials ⚠️
database/database.go 69.23% 4 Missing and 4 partials ⚠️
api/application.go 66.66% 2 Missing and 2 partials ⚠️
database/application.go 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
- Coverage   79.15%   78.70%   -0.46%     
==========================================
  Files          56       57       +1     
  Lines        2226     2517     +291     
==========================================
+ Hits         1762     1981     +219     
- Misses        360      397      +37     
- Partials      104      139      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@eternal-flame-AD eternal-flame-AD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

// example: AWH0wZ5r0Mbac.r
Token string `gorm:"type:varchar(180);uniqueIndex:uix_applications_token" json:"token"`
UserID uint `gorm:"index" json:"-"`
UserID uint `gorm:"index;uniqueIndex:idx_id_sortkey,priority:1" json:"-"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use the existing name convention (uix_application_user_id_sortkey)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Reorganize the list of "Apps"

3 participants