feat(config): add support for user-configurable ModuleRoot #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented ModuleRoot setting in %IPM.Repo.UniversalSettings - Added rwx permission validation for custom directory paths - Updated module installation logic to prioritize configured ModuleRoot - Included unit tests to verify path redirection and permission checks
AshokThangavel
requested review from
isc-dchui,
isc-egabhart,
isc-eneil,
isc-jili,
isc-jlechtne,
isc-kiyer,
isc-pbarton and
isc-tleavitt
as code owners
isc-kiyer
reviewed
Jan 13, 2026
| return ..GetValue(..#ModuleRoot) | ||
| } | ||
|
|
||
| ClassMethod CheckDirPermission(directory As %String = "") As %Status |
Collaborator
There was a problem hiding this comment.
Nit: just throw errors instead if returning status
Contributor
Author
There was a problem hiding this comment.
Thank you! I've updated the CheckDirPermission method to throw exception instead of returning the status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces the ability for users to configure a custom base directory for IPM module installations. Previously, modules were restricted to a path relative to the IRIS installation (typically within
<installedDir>/ipm/).With this change, users can use the
config setcommand to isolate source code and artifacts from the IRIS system folders, facilitating better DevOps practices and persistent storage management in containerized environments.fixes: #1029
Changes
ModuleRootas a valid setting in%IPM.Repo.UniversalSettings.ModuleRootover the default##class(%SYSTEM.Util).DataDirectory() _ "ipm/".Testing Results
objectscript-mathto default/usr/irissys/ipm/./usr/withERROR #5001: No write permission.ModuleRootto custom path:/tmp/./tmp/.