-
Notifications
You must be signed in to change notification settings - Fork 4
Upgrade React 18+ support and replace sortable tree patch #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: yi-nuo426 <218099172+yi-nuo426@users.noreply.github.com>
Co-authored-by: yi-nuo426 <218099172+yi-nuo426@users.noreply.github.com>
Co-authored-by: yi-nuo426 <218099172+yi-nuo426@users.noreply.github.com>
Co-authored-by: yi-nuo426 <218099172+yi-nuo426@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the package to require React 18+ (dropping support for React 16 and 17) and removes the deprecated react-sortable-tree-patch-react-17 dependency. The PR claims to replace the sortable tree package with @dnd-kit/core, but this replacement is incomplete as @dnd-kit/core has been added without any code integration.
Changes:
- Updated peer dependencies to require React 18+ (React 19 compatible)
- Removed
react-sortable-tree-patch-react-17and its transitive dependencies - Added
@dnd-kit/coredependency (though not used in code) - Updated README to document the React 18+ breaking change
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updated peer dependencies to React 18+, removed react-sortable-tree-patch-react-17, added @dnd-kit/core |
| package-lock.json | Reflected dependency changes including removal of sortable tree and addition of dnd-kit packages |
| README.md | Added documentation noting React 18+ requirement as a breaking change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| "dependencies": { | ||
| "@babel/runtime-corejs3": "^7.12.1", | ||
| "@dnd-kit/core": "^6.3.1", |
Copilot
AI
Jan 20, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @dnd-kit/core dependency has been added but is not used anywhere in the codebase. The existing drag-and-drop functionality uses react-dnd and react-dnd-html5-backend (which remain in dependencies). If the intention was to replace react-dnd with @dnd-kit/core, the implementation is incomplete. If @dnd-kit/core is not needed, it should be removed to avoid unnecessary dependencies.
| "@dnd-kit/core": "^6.3.1", |
|
@copilot |
Co-authored-by: yi-nuo426 <218099172+yi-nuo426@users.noreply.github.com>
|
@copilot continue / retry. |
Co-authored-by: yi-nuo426 <218099172+yi-nuo426@users.noreply.github.com>
The dev server now compiles successfully after updating the webpack Babel loader to transpile optional chaining/class properties in MUI dependencies. Screenshot: https://github.com/user-attachments/assets/a9bbb8ca-e674-484b-ae7f-5becbca685c9. Commit: 5d66c40. |
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.