Update L1 for Container Label #5449

dassayantan24 · 2026-01-13T14:41:15Z

Context

This change implements L1 tests for containers using Docker images, both with and without labels.

Work-Item [AB#2346693]- https://dev.azure.com/mseng/AzureDevOps/_workitems/edit/2346693

Description

Integration tests validating that the Azure Pipelines Agent reads the com.azure.dev.pipelines.agent.handler.node.path container label to resolve custom Node.js paths. Includes four platform-specific tests (Windows and Linux) that verify both label-based resolution and fallback behavior when the label is absent.

Risk Assessment (Low / Medium / High)

Low

Unit Tests Added or Updated (Yes / No)

Yes

Additional Testing Performed

NA

Change Behind Feature Flag (Yes / No)

No

Tech Design / Approach

Design has been written and reviewed. Yes
Any architectural decisions, trade-offs, and alternatives are captured.

Documentation Changes Required (Yes/No)

Indicate whether related documentation needs to be updated.

User guides, API specs, system diagrams, or runbooks are updated.

Logging Added/Updated (Yes/No)

Appropriate log statements are added with meaningful messages.
Logging does not expose sensitive data.
Log levels are used correctly (e.g., info, warn, error).

Telemetry Added/Updated (Yes/No)

Custom telemetry (e.g., counters, timers, error tracking) is added as needed.
Events are tagged with proper metadata for filtering and analysis.
Telemetry is validated in staging or test environments.

Rollback Scenario and Process (Yes/No)

Rollback plan is documented.

Dependency Impact Assessed and Regression Tested (Yes/No)

All impacted internal modules, APIs, services, and third-party libraries are analyzed.
Results are reviewed and confirmed to not break existing functionality.

dassayantan24 · 2026-01-13T14:41:27Z

/azp run

azure-pipelines · 2026-01-13T14:41:42Z

Azure Pipelines successfully started running 1 pipeline(s).

dassayantan24 · 2026-01-13T15:55:14Z

/azp run

azure-pipelines · 2026-01-13T15:55:27Z

Azure Pipelines successfully started running 1 pipeline(s).

dassayantan24 · 2026-01-13T16:42:46Z

/azp run

azure-pipelines · 2026-01-13T16:42:59Z

Azure Pipelines successfully started running 1 pipeline(s).

dassayantan24 · 2026-01-13T17:06:38Z

/azp run

azure-pipelines · 2026-01-13T17:06:51Z

Azure Pipelines successfully started running 1 pipeline(s).

rishabhmalikMS · 2026-01-15T06:06:37Z

src/Test/L1/Worker/ContainerLabelL1Tests.cs

+                SetupL1();
+                var message = LoadTemplateMessage();
+
+                var containerResource = new Microsoft.TeamFoundation.DistributedTask.Pipelines.ContainerResource()


Instead of creating object of type Microsoft.TeamFoundation.DistributedTask.Pipelines.ContainerResource, you can import it and create object of just ContainerResource. This would keep code clean.
Same for Code in line 82 for AgentJobRequestMessage

rishabhmalikMS · 2026-01-15T06:08:59Z

src/Test/L1/Worker/ContainerLabelL1Tests.cs

+        private async Task CreateTestContainerImageWindows()
+        {
+            string dockerfile = $@"FROM mcr.microsoft.com/windows/servercore/insider:10.0.20348.1
+LABEL ""{ContainerLabelKey}""=""{CustomNodePathWindows}""


Please fix the indentation here, same for below code.

rishabhmalikMS · 2026-01-15T06:14:52Z

src/Test/L1/Worker/ContainerLabelL1Tests.cs

+
+                var steps = GetSteps();
+                Assert.NotNull(steps);
+                Assert.True(steps.Count() >= 1);


The tests don't actually verify that the container label is being read and used. The assertions only check that steps exist or not. Can we validate that the custom node via label is actually used vs the agent's build in node.

These tests are more like verifying that the agent doesn't crash when running containerized jobs with labels and without labels, as we don't have any container L1 tests for the agent. The label checking logic is mostly covered in the L0 PR that I have raised. Though I'll try to check if it's possible to validate custom node via label.

if label checking logic is part of L0 tests, how this validates worker crashed or not?
what are the scenario in which worker will crash

I have updated the ValidateNodePathUsage method to validate that the custom node path from the Docker label appears in the container execution logs.

sanjuyadav24 · 2026-01-19T08:50:55Z

src/Test/L1/Worker/ContainerLabelL1Tests.cs

+        private const string TestImageNameLinux = "azure-pipelines-agent-test-container-label-linux";
+        private const string TestImageNameWindowsNoLabel = "azure-pipelines-agent-test-container-nolabel-windows";
+        private const string TestImageNameLinuxNoLabel = "azure-pipelines-agent-test-container-nolabel-linux";
+        private const string CustomNodePathWindows = "C:\\Program Files\\nodejs\\node.exe";


how do we validate this path in ci/cd pipelines?

The CI/CD validates the path by running a real container job and asserting that pathe appears in the execution logs. in method ValidateNodePathUsage

sanjuyadav24 · 2026-01-19T08:53:17Z

src/Test/L1/Worker/ContainerLabelL1Tests.cs

+
+                var steps = GetSteps();
+                Assert.NotNull(steps);
+                Assert.True(steps.Count() >= 1);


if label checking logic is part of L0 tests, how this validates worker crashed or not?
what are the scenario in which worker will crash

dassayantan24 · 2026-01-20T08:51:52Z

/azp run

azure-pipelines · 2026-01-20T08:52:06Z

Azure Pipelines successfully started running 1 pipeline(s).

dassayantan24 · 2026-01-20T12:08:10Z

/azo run

dassayantan24 · 2026-01-20T12:08:17Z

/azp run

azure-pipelines · 2026-01-20T12:08:31Z

Azure Pipelines successfully started running 1 pipeline(s).

dassayantan24 · 2026-01-25T19:52:38Z

/azp run

azure-pipelines · 2026-01-25T19:52:50Z

Azure Pipelines successfully started running 1 pipeline(s).

dassayantan24 · 2026-01-26T06:47:40Z

/azp run

azure-pipelines · 2026-01-26T06:47:52Z

Azure Pipelines successfully started running 1 pipeline(s).

…tant

dassayantan24 · 2026-01-26T07:18:31Z

/azp run

azure-pipelines · 2026-01-26T07:18:44Z

Azure Pipelines successfully started running 1 pipeline(s).

Update L1 test

8a239dc

update docker image

95e3895

Update L1 tests

4c4043d

Fix Linux L1 tests

0f75c61

dassayantan24 changed the title ~~Update L1 test~~ Update L1 for Container Label Jan 14, 2026

dassayantan24 added the internal label Jan 14, 2026

dassayantan24 marked this pull request as ready for review January 14, 2026 06:22

dassayantan24 requested review from a team as code owners January 14, 2026 06:22

rishabhmalikMS reviewed Jan 15, 2026

View reviewed changes

sanjuyadav24 reviewed Jan 19, 2026

View reviewed changes

Fix indentation and formatting in ContainerLabelL1Tests

025775f

dassayantan24 added 2 commits January 20, 2026 17:37

Add node path verification in Logs

54f4b0b

Merge branch 'master' into users/dassayantan/l1-for-container-label

6407520

Fix windows tests

969a3fa

Fix Linux container tests - install bash in Alpine images

be76e7f

dassayantan24 added 2 commits January 26, 2026 12:48

Use Ubuntu 22.04 for Linux container tests with proper node path cons…

11b6ede

…tant

Merge branch 'master' into users/dassayantan/l1-for-container-label

b43d1aa

Update L1 for Container Label #5449

Are you sure you want to change the base?

Update L1 for Container Label #5449

Conversation

dassayantan24 commented Jan 13, 2026 • edited by azure-boards bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Description

Risk Assessment (Low / Medium / High)

Unit Tests Added or Updated (Yes / No)

Additional Testing Performed

Change Behind Feature Flag (Yes / No)

Tech Design / Approach

Documentation Changes Required (Yes/No)

Logging Added/Updated (Yes/No)

Telemetry Added/Updated (Yes/No)

Rollback Scenario and Process (Yes/No)

Dependency Impact Assessed and Regression Tested (Yes/No)

Uh oh!

dassayantan24 commented Jan 13, 2026

Uh oh!

azure-pipelines bot commented Jan 13, 2026

Uh oh!

dassayantan24 commented Jan 13, 2026

Uh oh!

azure-pipelines bot commented Jan 13, 2026

Uh oh!

dassayantan24 commented Jan 13, 2026

Uh oh!

azure-pipelines bot commented Jan 13, 2026

Uh oh!

dassayantan24 commented Jan 13, 2026

Uh oh!

azure-pipelines bot commented Jan 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dassayantan24 commented Jan 20, 2026

Uh oh!

azure-pipelines bot commented Jan 20, 2026

Uh oh!

dassayantan24 commented Jan 20, 2026

Uh oh!

dassayantan24 commented Jan 20, 2026

Uh oh!

azure-pipelines bot commented Jan 20, 2026

Uh oh!

dassayantan24 commented Jan 25, 2026

Uh oh!

azure-pipelines bot commented Jan 25, 2026

Uh oh!

dassayantan24 commented Jan 26, 2026

Uh oh!

azure-pipelines bot commented Jan 26, 2026

Uh oh!

dassayantan24 commented Jan 26, 2026

Uh oh!

azure-pipelines bot commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

dassayantan24 commented Jan 13, 2026 •

edited by azure-boards bot

Loading