Skip to content

Conversation

@amyssnippet
Copy link

fixes #290146

As of VS Code 1.91 (via #243283), the lineComment property in CommentRule can be an object (LineCommentConfig) in addition to a string. This PR updates the interface to string | LineCommentConfig to match the runtime behavior and prevent type errors for consumers.

@amyssnippet
Copy link
Author

@amyssnippet please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@RedCMD
Copy link
Contributor

RedCMD commented Jan 24, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[@types/vscode] The type for lineComment in CommentRule interface is out of date

4 participants