fix: persist agent harness selection across window reload #290160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes issue #290157 where the agent harness selection (Local, Background, Cloud, Claude) was resetting to 'Local' on window reload.
Changes:
- Adds persistent storage for agent harness selection using storage key
agentSessionsWelcome.selectedSessionProvider - Restores the persisted selection in the constructor with fallback to Local
- Stores the selection when the user changes it via the session type picker
src/vs/workbench/contrib/welcomeAgentSessions/browser/agentSessionsWelcome.ts
Outdated
Show resolved
Hide resolved
Fixes microsoft#290157 The agent harness choice (Local, Background, Cloud, Claude) was resetting to 'Local' on window reload because the selection was not persisted. This change: - Adds storage key 'agentSessionsWelcome.selectedSessionProvider' - Restores persisted selection in constructor (defaults to Local) - Stores selection when user changes it
raman-kumar8
force-pushed
the
fix/persist-agent-harness-selection-290157
branch
from
541e0f3 to
4e9cca9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290157
The agent harness choice (Local, Background, Cloud, Claude) was resetting to 'Local' on window reload because the selection was not persisted.
This change:
]