-
Notifications
You must be signed in to change notification settings - Fork 37.6k
animations for reasoning and tool calls inside reasoning #290216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds animations and UI enhancements for reasoning and tool calls during chat thinking/reasoning operations. It introduces a shimmer effect for working messages and a rotating set of status messages to provide better visual feedback during model reasoning.
Changes:
- Added CSS shimmer animation effect for the working spinner label
- Implemented rotating working status messages ("Thinking...", "Processing...", etc.)
- Updated collapse button icon logic to show different icons based on streaming state and expand/collapse status
- Added persistent working spinner element that appears during streaming and is removed when complete
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| chatThinkingContent.css | Added keyframe animation for shimmer effect and CSS rules for the working spinner element with shimmer styling |
| chatThinkingContentPart.ts | Added working messages array, spinner element lifecycle management, DOM insertion logic to keep spinner at bottom, and updated collapse button icon behavior |
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts:1062
- Extra blank line should be removed. A single blank line is sufficient for separation between code blocks.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatThinkingContent.css
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatThinkingContent.css
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
working.animations.mov