Skip to content

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Jan 26, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 26, 2026 15:28
@bpasero bpasero enabled auto-merge (squash) January 26, 2026 15:28
@bpasero bpasero self-assigned this Jan 26, 2026
@vs-code-engineering
Copy link

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@joaomoreno

Matched files:

  • src/vs/base/browser/ui/tree/asyncDataTree.ts

@benibenj

Matched files:

  • src/vs/base/browser/ui/tree/asyncDataTree.ts

@Tyriar

Matched files:

  • src/vs/platform/terminal/node/terminalProcess.ts

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes redundant TypeScript import aliases where the imported symbol was being re-aliased to the exact same name (e.g. Foo as Foo), reducing noise and improving readability.

Changes:

  • Simplified named imports by removing same-name as aliases across workbench, editor, base, and platform code.
  • Kept import symbols unchanged (no behavioral/runtime changes expected).

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/vs/workbench/services/mcp/browser/mcpGalleryManifestService.ts Removes redundant alias on McpGalleryManifestService import.
src/vs/workbench/services/extensionManagement/electron-browser/extensionGalleryManifestService.ts Removes redundant alias on ExtensionGalleryManifestService import.
src/vs/workbench/services/extensionManagement/browser/extensionGalleryManifestService.ts Removes redundant alias on ExtensionGalleryManifestService import.
src/vs/workbench/contrib/terminal/common/remote/terminal.ts Removes redundant alias on ISerializableEnvironmentDescriptionMap import.
src/vs/workbench/contrib/terminal/common/remote/remoteTerminalChannel.ts Removes redundant alias on ISerializableEnvironmentDescriptionMap import.
src/vs/workbench/contrib/notebook/common/notebookOutputRenderer.ts Removes redundant alias on INotebookStaticPreloadInfo import.
src/vs/workbench/contrib/notebook/browser/services/notebookServiceImpl.ts Removes redundant alias on NotebookStaticPreloadInfo import.
src/vs/workbench/contrib/customEditor/browser/customEditor.contribution.ts Removes redundant alias on ComplexCustomWorkingCopyEditorHandler import.
src/vs/workbench/api/common/extHostLoggerService.ts Removes redundant alias on ExtHostLogLevelServiceShape import.
src/vs/platform/terminal/node/terminalProcess.ts Removes redundant alias on IProcessPropertyMap import.
src/vs/platform/terminal/common/environmentVariableShared.ts Removes redundant alias on ISerializableEnvironmentDescriptionMap import.
src/vs/editor/contrib/folding/browser/folding.ts Removes redundant alias on getParentFoldLine import.
src/vs/base/browser/ui/tree/asyncDataTree.ts Removes redundant alias on TreeFindMode import.

@bpasero bpasero merged commit 05c127e into main Jan 26, 2026
27 of 28 checks passed
@bpasero bpasero deleted the ben/sunny-earwig branch January 26, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants